Test that the fixups are generated if display name is empty #1267
+56
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change: just adds new test cases for the change in swiftlang#1256 * Moved the tests previously added to `apiMisuseErrors` -> `apiMisuseErrorsIncludingFixIts`, and include the expected fixits It would probably be ok to leave them in `apiMisuseErrors` as well, but I think it would be kinda redundant since we also test the expected message along with the fixits already.
jerryjrchen
requested review from
stmontgomery,
grynspan,
briancroom and
suzannaratcliff
as code owners
grynspan
added
enhancement
stmontgomery
approved these changes
Aug 14, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change: just adds new test cases for the change in #1256
Motivation:
Slightly improves effective test coverage for Stuart's earlier change.
Modifications:
Moved the tests previously added to
apiMisuseErrors->apiMisuseErrorsIncludingFixIts, and include the expected fixitsIt would probably be ok to leave them in
apiMisuseErrorsas well, but I think it would be kinda redundant since we also test the expected message along with the fixits already.Checklist: